Re: [PR] Fix terms, typos and grammar mistakes in the API, error messages, events, etc. [cloudstack]

Wed, 17 Sep 2025 12:41:53 -0700 


rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332676030


##########
plugins/hypervisors/vmware/src/main/java/com/cloud/api/response/CiscoNexusVSMResponse.java:
##########
@@ -29,35 +29,35 @@
 public class CiscoNexusVSMResponse extends BaseResponse {
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_ID)
-    @Param(description = "device id of the Cisco N1KV VSM device")
+    @Param(description = "Device id of the Cisco N1KV VSM device")
     private String id;
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_NAME)
-    @Param(description = "device name")
+    @Param(description = "Device name")
     private String deviceName;
 
     @SerializedName(ApiConstants.IP_ADDRESS)
-    @Param(description = "the management IP address of the external Cisco 
Nexus 1000v Virtual Supervisor Module")
+    @Param(description = "The management IP address of the external Cisco 
Nexus 1000v Virtual Supervisor Module")
     private String vsmmgmtIpAddress;
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_STATE)
-    @Param(description = "device state")
+    @Param(description = "Device state")
     private String deviceState;
 
     @SerializedName(ApiConstants.VSM_MGMT_VLAN_ID)
-    @Param(description = "management vlan id of the VSM")
+    @Param(description = "Management VLAN id of the VSM")
     private String vsmmgmtvlanid;
 
     @SerializedName(ApiConstants.VSM_CTRL_VLAN_ID)
-    @Param(description = "control vlan id of the VSM")
+    @Param(description = "Control VLAN id of the VSM")

Review Comment:
   'ID'



##########
plugins/hypervisors/vmware/src/main/java/com/cloud/api/response/CiscoNexusVSMResponse.java:
##########
@@ -29,35 +29,35 @@
 public class CiscoNexusVSMResponse extends BaseResponse {
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_ID)
-    @Param(description = "device id of the Cisco N1KV VSM device")
+    @Param(description = "Device id of the Cisco N1KV VSM device")
     private String id;
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_NAME)
-    @Param(description = "device name")
+    @Param(description = "Device name")
     private String deviceName;
 
     @SerializedName(ApiConstants.IP_ADDRESS)
-    @Param(description = "the management IP address of the external Cisco 
Nexus 1000v Virtual Supervisor Module")
+    @Param(description = "The management IP address of the external Cisco 
Nexus 1000v Virtual Supervisor Module")
     private String vsmmgmtIpAddress;
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_STATE)
-    @Param(description = "device state")
+    @Param(description = "Device state")
     private String deviceState;
 
     @SerializedName(ApiConstants.VSM_MGMT_VLAN_ID)
-    @Param(description = "management vlan id of the VSM")
+    @Param(description = "Management VLAN id of the VSM")
     private String vsmmgmtvlanid;
 
     @SerializedName(ApiConstants.VSM_CTRL_VLAN_ID)
-    @Param(description = "control vlan id of the VSM")
+    @Param(description = "Control VLAN id of the VSM")
     private int vsmctrlvlanid;
 
     @SerializedName(ApiConstants.VSM_PKT_VLAN_ID)
-    @Param(description = "packet vlan id of the VSM")
+    @Param(description = "Packet VLAN id of the VSM")

Review Comment:
   'ID'



##########
plugins/hypervisors/vmware/src/main/java/com/cloud/api/response/CiscoNexusVSMResponse.java:
##########
@@ -29,35 +29,35 @@
 public class CiscoNexusVSMResponse extends BaseResponse {
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_ID)
-    @Param(description = "device id of the Cisco N1KV VSM device")
+    @Param(description = "Device id of the Cisco N1KV VSM device")
     private String id;
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_NAME)
-    @Param(description = "device name")
+    @Param(description = "Device name")
     private String deviceName;
 
     @SerializedName(ApiConstants.IP_ADDRESS)
-    @Param(description = "the management IP address of the external Cisco 
Nexus 1000v Virtual Supervisor Module")
+    @Param(description = "The management IP address of the external Cisco 
Nexus 1000v Virtual Supervisor Module")
     private String vsmmgmtIpAddress;
 
     @SerializedName(ApiConstants.EXTERNAL_SWITCH_MGMT_DEVICE_STATE)
-    @Param(description = "device state")
+    @Param(description = "Device state")
     private String deviceState;
 
     @SerializedName(ApiConstants.VSM_MGMT_VLAN_ID)
-    @Param(description = "management vlan id of the VSM")
+    @Param(description = "Management VLAN id of the VSM")
     private String vsmmgmtvlanid;
 
     @SerializedName(ApiConstants.VSM_CTRL_VLAN_ID)
-    @Param(description = "control vlan id of the VSM")
+    @Param(description = "Control VLAN id of the VSM")
     private int vsmctrlvlanid;
 
     @SerializedName(ApiConstants.VSM_PKT_VLAN_ID)
-    @Param(description = "packet vlan id of the VSM")
+    @Param(description = "Packet VLAN id of the VSM")
     private int vsmpktvlanid;
 
     @SerializedName(ApiConstants.VSM_STORAGE_VLAN_ID)
-    @Param(description = "storage vlan id of the VSM")
+    @Param(description = "Storage VLAN id of the VSM")

Review Comment:
   'ID'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to