sureshanaparti opened a new pull request, #11666: URL: https://github.com/apache/cloudstack/pull/11666
### Description This PR updates the default value of the setting 'mount.disabled.storage.pool' to true, and mounts the disabled pools by default (for new installations only, old installation should explicitly update the setting to true if required). It brings back the previous default behavior. **Issue** The disabled pools that are unmounted & entries removed from _storage_pool_host_ref_ table during host disconnection (on management server / agent stop through ) are not re-mounted & added back to _storage_pool_host_ref_ table during host connection (on management server / agent start), resulting in access issues for the existing volumes on them (and impacting the VM/Volume operations). https://github.com/apache/cloudstack/blob/0cbebbddddab9944747cc57773f79a0dcfbd81ea/plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java#L119-L124 https://github.com/apache/cloudstack/blob/0cbebbddddab9944747cc57773f79a0dcfbd81ea/plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/provider/SolidFireSharedHostListener.java#L118-L123 https://github.com/apache/cloudstack/blob/0cbebbddddab9944747cc57773f79a0dcfbd81ea/plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/provider/AdaptivePrimaryHostListener.java#L90-L96 https://github.com/apache/cloudstack/blob/0cbebbddddab9944747cc57773f79a0dcfbd81ea/plugins/storage/volume/cloudbyte/src/main/java/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java#L126-L131 https://github.com/apache/cloudstack/blob/0cbebbddddab9944747cc57773f79a0dcfbd81ea/plugins/storage/volume/datera/src/main/java/org/apache/cloudstack/storage/datastore/provider/DateraHostListener.java#L112-L117 **Background** The disabled pools are mounted by default until 4.17.0.0, that means host/pool entries were added for the disabled pools in _storage_pool_host_ref_ table till 4.17.0. The setting 'mount.disabled.storage.pool' (introduced in 4.17.0.0) is false by default, and doesn't allow mount of disabled pools which breaks the default behavior. There was a discussion about keeping the default behavior in the PR https://github.com/apache/cloudstack/pull/6164 (where the setting 'mount.disabled.storage.pool' is introduced), but it was not addressed. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
