harikrishna-patnala commented on PR #10710: URL: https://github.com/apache/cloudstack/pull/10710#issuecomment-3317079904
> @vishesh92 @harikrishna-patnala @weizhouapache , there is a slight backwards incompatibility with this change; success can now be true, false or not present. In addition to result there is status, which can be “success”, “failure”, “warning” or “unknown”. So the incompatibilty is that result may not be present. I think this is not grave as it would be a false positive in the past. What do you think? > > Other than this we are good to merge (@vladimirpetrov tested but forgot to give his opinion here;) as we are only updating the value of the response parameter properly I think this is fine and moreover more detailed 'status' is now present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
