DaanHoogland commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2374586400
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java:
##########
@@ -93,10 +93,14 @@ protected boolean isUserDisabled(SearchResult result)
throws NamingException {
}
protected String getMemberOfAttribute(final Long domainId) {
+ String rc;
if(_ldapConfiguration.isNestedGroupsEnabled(domainId)) {
- return MICROSOFT_AD_NESTED_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_NESTED_MEMBERS_FILTER;
} else {
- return MICROSOFT_AD_MEMBERS_FILTER;
+ rc = MICROSOFT_AD_MEMBERS_FILTER;
}
+ logger.debug("memberOf filter = " + rc);
Review Comment:
it is debug message to ensure the AD provider is used and in the right way.
We could remove or make it trace.
the only detail to add at this point is the domainid.
```suggestion
logger.trace(“using memberOf filter = {} for domain with id {}”, rc,
domainId);
```
Is that what you mean, @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
