hsato03 commented on code in PR #10282:
URL: https://github.com/apache/cloudstack/pull/10282#discussion_r2382363359
##########
core/src/main/java/org/apache/cloudstack/storage/to/VolumeObjectTO.java:
##########
@@ -343,6 +344,10 @@ public void setDeviceId(Long deviceId) {
}
public void setCacheMode(DiskCacheMode cacheMode) {
+ if (DiskCacheMode.HYPERVISOR_DEFAULT.equals(cacheMode) &&
!Hypervisor.HypervisorType.KVM.equals(hypervisorType)) {
+ this.cacheMode = DiskOffering.DiskCacheMode.NONE;
Review Comment:
@weizhouapache @DaanHoogland
I added some changes with my last commit. Could you please take a look and
check if your concerns have been addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
