Copilot commented on code in PR #11843:
URL: https://github.com/apache/cloudstack/pull/11843#discussion_r2432987368
##########
plugins/user-authenticators/ldap/src/test/java/org/apache/cloudstack/ldap/ADLdapUserManagerImplTest.java:
##########
@@ -54,7 +54,7 @@ public void
testGenerateADSearchFilterWithNestedGroupsEnabled() {
String [] groups = {"dev", "dev-hyd"};
for (String group: groups) {
String result =
adLdapUserManager.generateADGroupSearchFilter(group, 1L);
-
assertTrue(("(&(objectClass=user)(memberOf:1.2.840.113556.1.4.1941:=CN=" +
group + ",DC=cloud,DC=citrix,DC=com))").equals(result));
+
assertTrue(("(&(objectCategory=person)(objectClass=user)(memberOf:1.2.840.113556.1.4.1941:=CN="
+ group + ",DC=cloud,DC=citrix,DC=com))").equals(result));
Review Comment:
Use assertEquals for clearer failure messages and intent:
assertEquals(\"(&(objectCategory=person)(objectClass=user)(memberOf:1.2.840.113556.1.4.1941:=CN=\"
+ group + \",DC=cloud,DC=citrix,DC=com))\", result).
##########
plugins/user-authenticators/ldap/src/test/java/org/apache/cloudstack/ldap/ADLdapUserManagerImplTest.java:
##########
@@ -69,7 +69,7 @@ public void
testGenerateADSearchFilterWithNestedGroupsDisabled() {
String [] groups = {"dev", "dev-hyd"};
for (String group: groups) {
String result =
adLdapUserManager.generateADGroupSearchFilter(group, 1L);
- assertTrue(("(&(objectClass=user)(memberOf=CN=" + group +
",DC=cloud,DC=citrix,DC=com))").equals(result));
+
assertTrue(("(&(objectCategory=person)(objectClass=user)(memberOf=CN=" + group
+ ",DC=cloud,DC=citrix,DC=com))").equals(result));
Review Comment:
Use assertEquals for better readability and diagnostics:
assertEquals(\"(&(objectCategory=person)(objectClass=user)(memberOf=CN=\" +
group + \",DC=cloud,DC=citrix,DC=com))\", result).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
