shwstppr commented on code in PR #11770:
URL: https://github.com/apache/cloudstack/pull/11770#discussion_r2412984643
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -982,6 +982,19 @@ private void
updateCustomDisplayNameOnHypervisorsList(String previousValue, Stri
}
}
+ protected String getNormalizedEmptyValueForConfig(final String name, final
String inputValue,
+ final Long configStorageId) {
+ String value = inputValue.trim();
+ if (!value.isEmpty() && !value.equals("null")) {
+ return value;
+ }
+ if (configStorageId != null) {
+ return "";
+ }
+ ConfigKey<?> key = _configDepot.get(name);
+ return (key != null && key.type() == String.class) ? "" : null;
Review Comment:
@DaanHoogland I feel we should let updateConfiguration set empty string `""`
If the operator wants NULL(if NULL is default value), resetConfiguration API
can be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
