abh1sar commented on code in PR #11782:
URL: https://github.com/apache/cloudstack/pull/11782#discussion_r2410712861
##########
engine/schema/src/main/java/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java:
##########
@@ -150,6 +150,16 @@ public VMTemplateStoragePoolVO findByPoolTemplate(long
poolId, long templateId,
return findOneIncludingRemovedBy(sc);
}
+ @Override
+ public List<VMTemplateStoragePoolVO> listByPoolIdsAndTemplate(List<Long>
poolIds, Long templateId) {
+ SearchCriteria<VMTemplateStoragePoolVO> sc =
PoolTemplateSearch.create();
+ if (CollectionUtils.isNotEmpty(poolIds)) {
+ sc.setParameters("pool_id", poolIds.toArray());
+ }
Review Comment:
@weizhouapache no, the method is supposed to return all template_spool_refs
if poolIds is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
