Pearl1594 commented on code in PR #11841:
URL: https://github.com/apache/cloudstack/pull/11841#discussion_r2433201787
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListImportVMTasksCmd.java:
##########
@@ -75,11 +76,8 @@ public class ListImportVMTasksCmd extends BaseListCmd {
description = "Conversion host of the importing task")
private Long convertHostId;
- @Parameter(name = ApiConstants.LIST_ALL, type = CommandType.BOOLEAN,
description = "Whether to list all import tasks.")
- private boolean listAll = false;
-
- @Parameter(name = ApiConstants.SHOW_COMPLETED, type = CommandType.BOOLEAN,
description = "Whether to list completed tasks.")
- private boolean showCompleted = false;
+ @Parameter(name = ApiConstants.STATE, type = CommandType.STRING,
description = "List tasks by status, valid options are: Running, Completed,
Failed")
Review Comment:
should we add a since field?
##########
api/src/main/java/org/apache/cloudstack/api/response/ImportVMTaskResponse.java:
##########
@@ -55,6 +55,10 @@ public class ImportVMTaskResponse extends BaseResponse {
@Param(description = "the display name of the importing VM")
private String displayName;
+ @SerializedName(ApiConstants.STATE)
+ @Param(description = "the state of the importing VM task")
Review Comment:
since?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
