vishesh92 commented on code in PR #11462:
URL: https://github.com/apache/cloudstack/pull/11462#discussion_r2391144497
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java:
##########
@@ -257,6 +258,19 @@ public LdapUserResponse createLdapUserResponse(final
LdapUser user) {
@Override
public LdapConfigurationResponse deleteConfiguration(final
LdapDeleteConfigurationCmd cmd) throws InvalidParameterValueException {
+ Long id = cmd.getId();
+ String hostname = cmd.getHostname();
+ if (id == null && StringUtils.isEmpty(hostname)) {
+ throw new InvalidParameterValueException("Either id or hostname
must be specified");
+ }
+ if (id != null) {
Review Comment:
We can document that other parameters are ignored when id is passed or throw
an error here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
