harikrishna-patnala commented on code in PR #11616:
URL: https://github.com/apache/cloudstack/pull/11616#discussion_r2374523595
##########
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java:
##########
@@ -399,7 +399,7 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
vsDisplayName, String vsDesc
_accountMgr.checkAccess(caller, null, true, userVmVo);
// check max snapshot limit for per VM
- int vmSnapshotMax = VMSnapshotManager.VMSnapshotMax.value();
+ int vmSnapshotMax =
VMSnapshotManager.VMSnapshotMax.valueIn(userVmVo.getAccountId());
Review Comment:
@bernardodemarco thanks for investigating. When I checked other account
level global settings, they are all considering the caller account id only, for
example "allow.user.expunge.recover.volume". That sounds correct to me, if a
caller could perform the operation on the VM consider that account settings in
a project. Let me know if this sounds good to you.
cc @DaanHoogland @weizhouapache @sureshanaparti @shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
