vishesh92 commented on code in PR #11591:
URL: https://github.com/apache/cloudstack/pull/11591#discussion_r2418838759
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2411,6 +2411,21 @@ public Pair<List<? extends ConfigurationGroup>, Integer>
listConfigurationGroups
return new Pair<>(result.first(), result.second());
}
+ protected List<IpAddress.State> getStatesForIpAddressSearch(final
ListPublicIpAddressesCmd cmd) {
+ final String state = cmd.getState();
+ final List<IpAddress.State> states = new ArrayList<>();
+ if (StringUtils.isNotBlank(state)) {
+ for (String s : StringUtils.split(state, ",")) {
+ try {
+ states.add(IpAddress.State.valueOf(s));
Review Comment:
Do we need to trim `s` and also check for case sensitivity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
