shwstppr commented on code in PR #10506: URL: https://github.com/apache/cloudstack/pull/10506#discussion_r2371332478
########## framework/quota/src/main/java/org/apache/cloudstack/quota/vo/QuotaUsageDetailVO.java: ########## @@ -0,0 +1,86 @@ +//Licensed to the Apache Software Foundation (ASF) under one +//or more contributor license agreements. See the NOTICE file +//distributed with this work for additional information +//regarding copyright ownership. The ASF licenses this file +//to you under the Apache License, Version 2.0 (the +//"License"); you may not use this file except in compliance +//with the License. You may obtain a copy of the License at +// +//http://www.apache.org/licenses/LICENSE-2.0 +// +//Unless required by applicable law or agreed to in writing, +//software distributed under the License is distributed on an +//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +//KIND, either express or implied. See the License for the +//specific language governing permissions and limitations +//under the License. +package org.apache.cloudstack.quota.vo; + +import java.math.BigDecimal; + +import javax.persistence.Column; +import javax.persistence.Entity; +import javax.persistence.Id; +import javax.persistence.Table; +import org.apache.cloudstack.api.InternalIdentity; +import org.apache.commons.lang3.builder.ReflectionToStringBuilder; +import org.apache.commons.lang3.builder.ToStringStyle; + +@Entity +@Table(name = "quota_usage_detail") Review Comment: I feel table should be named differently as CLoudStack uses `*_detail` table for the details of the entity mostly in the similar format resource_id,name,value ########## engine/schema/src/main/java/com/cloud/user/dao/AccountDao.java: ########## @@ -49,6 +49,8 @@ public interface AccountDao extends GenericDao<AccountVO, Long> { List<AccountVO> listAccounts(String accountName, Long domainId, Filter filter); + AccountVO findAccountByNameAndDomainIncludingRemoved(String accountName, Long domainId); Review Comment: same as `findAccountIncludingRemoved` ########## framework/quota/src/main/java/org/apache/cloudstack/quota/vo/QuotaUsageResourceVO.java: ########## @@ -0,0 +1,62 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +package org.apache.cloudstack.quota.vo; + +import java.util.Date; + +public class QuotaUsageResourceVO { Review Comment: Is this referring to any DB table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
