shwstppr commented on code in PR #11567:
URL: https://github.com/apache/cloudstack/pull/11567#discussion_r2429722685
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -980,7 +980,7 @@ public BackupProvider getBackupProvider(final String name) {
@Override
public List<Class<?>> getCommands() {
final List<Class<?>> cmdList = new ArrayList<Class<?>>();
- if (!BackupFrameworkEnabled.value()) {
+ if (!BackupFrameworkEnabled.value() &&
!BackupFrameworkEnabled.hasValueInScope(Boolean.TRUE.toString())) {
Review Comment:
We should not restrict API access if based on the zone config value. It
might break UI/clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
