weizhouapache commented on code in PR #11819:
URL: https://github.com/apache/cloudstack/pull/11819#discussion_r2465943756
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/autoscale/DeleteAutoScaleConditionCounterCmd.java:
##########
@@ -34,7 +34,7 @@
@APICommand(name = "deleteCounter", description = "Deletes a counter for VM
auto scaling", responseObject = SuccessResponse.class,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
-public class DeleteCounterCmd extends BaseAsyncCmd {
+public class DeleteAutoScaleConditionCounterCmd extends BaseAsyncCmd {
Review Comment:
===> DeleteAutoScaleCounterCmd ?
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/autoscale/CreateCounterForAutoScaleConditionCmd.java:
##########
@@ -34,7 +34,7 @@
@APICommand(name = "createCounter", description = "Adds metric counter for VM
auto scaling", responseObject = CounterResponse.class,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
-public class CreateCounterCmd extends BaseAsyncCreateCmd {
+public class CreateCounterForAutoScaleConditionCmd extends BaseAsyncCreateCmd {
Review Comment:
===> CreateAutoScaleCounterCmd ?
##########
api/src/main/java/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleConditionCountersCmd.java:
##########
@@ -33,7 +33,7 @@
@APICommand(name = "listCounters", description = "List the counters for VM
auto scaling", responseObject = CounterResponse.class,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
-public class ListCountersCmd extends BaseListCmd {
+public class ListAutoScaleConditionCountersCmd extends BaseListCmd {
Review Comment:
==> ListAutoScaleCountersCmd ?
##########
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java:
##########
@@ -1527,7 +1527,7 @@ public Condition createCondition(CreateConditionCmd cmd) {
}
@Override
- public List<? extends Counter> listCounters(ListCountersCmd cmd) {
Review Comment:
will you rename Counter and Condition class too ?
can do later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
