sureshanaparti commented on code in PR #11656:
URL: https://github.com/apache/cloudstack/pull/11656#discussion_r2510044637
##########
client/bindir/cloud-setup-management.in:
##########
@@ -53,6 +157,22 @@ if __name__ == '__main__':
if options.nostart:
glbEnv.noStart = True
+ available_templates = ["kvm-aarch64", "kvm-x86_64", "xenserver", "vmware"]
+ templates_arg = options.systemvm_templates
+
+ selected_templates = ["kvm-x86_64"]
+ if templates_arg:
+ templates_list = [t.strip().lower() for t in templates_arg.split(",")]
+ if "all" in templates_list:
+ selected_templates = available_templates
+ else:
+ selected_templates = [t for t in templates_list if t in
available_templates]
+ print(f"Selected systemvm templates to download: {',
'.join(selected_templates) if selected_templates else 'None'}")
Review Comment:
can throw any error when providing invalid template option, say _kvm-amd_?
check for the inputs like _all,kvm-aarch64; kvm-aarch64,all_ - both cases,
assuming it considers all templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
