sureshanaparti commented on code in PR #11656:
URL: https://github.com/apache/cloudstack/pull/11656#discussion_r2521752079
##########
engine/schema/templateConfig.sh:
##########
@@ -82,13 +83,21 @@ function createMetadataFile() {
declare -a templates
getTemplateVersion $1
-templates=(
"kvm-x86_64:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvmtemplate-$VERSION-x86_64-kvm.qcow2.bz2";
-
"kvm-aarch64:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvmtemplate-$VERSION-aarch64-kvm.qcow2.bz2";
-
"vmware:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvmtemplate-$VERSION-x86_64-vmware.ova";
-
"xenserver:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-x86_64-xen.vhd.bz2";
-
"hyperv:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-x86_64-hyperv.vhd.zip";
-
"lxc:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-x86_64-kvm.qcow2.bz2";
-
"ovm3:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-x86_64-ovm.raw.bz2";
)
+declare -A template_specs=(
+ [kvm-x86_64]="x86_64-kvm.qcow2.bz2"
+ [kvm-aarch64]="aarch64-kvm.qcow2.bz2"
+ [vmware]="x86_64-vmware.ova"
+ [xenserver]="x86_64-xen.vhd.bz2"
+ [hyperv]="x86_64-hyperv.vhd.zip"
+ [lxc]="x86_64-kvm.qcow2.bz2"
+ [ovm3]="x86_64-ovm.raw.bz2"
Review Comment:
should we still keep hyper, lxc, ovm3? these are not valid options from
setup cmd as well. cc @DaanHoogland
ovm deprecated here - https://github.com/apache/cloudstack/pull/11196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
