DaanHoogland commented on code in PR #12062:
URL: https://github.com/apache/cloudstack/pull/12062#discussion_r2527615873
##########
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##########
@@ -456,6 +448,31 @@ public DeployDestination
planDeployment(VirtualMachineProfile vmProfile, Deploym
return dest;
}
+ private Host checkDeployInVmLastHost(VirtualMachineProfile vmProfile,
VirtualMachine vm) {
+ String considerLastHostStr =
(String)vmProfile.getParameter(VirtualMachineProfile.Param.ConsiderLastHost);
+ String haVmTag =
(String)vmProfile.getParameter(VirtualMachineProfile.Param.HaTag);
+ boolean considerLastHost = vm.getLastHostId() != null && haVmTag ==
null &&
+ (considerLastHostStr == null ||
Boolean.TRUE.toString().equalsIgnoreCase(considerLastHostStr));
Review Comment:
@nvazquez , true is the documented default, so we should treat null as true.
(if it is not passed in the parameters, I actually do not know if that would be
handled upstream already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
