Copilot commented on code in PR #12086:
URL: https://github.com/apache/cloudstack/pull/12086#discussion_r2563966707
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -1619,7 +1619,7 @@ to support snapshots(backuped) as qcow2 files. */
destFile = new QemuImgFile(destPath, destFormat);
try {
boolean isQCOW2 =
PhysicalDiskFormat.QCOW2.equals(sourceFormat);
- qemu.convert(srcFile, destFile, null, null, new
QemuImageOptions(srcFile.getFormat(), srcFile.getFileName(), null),
+ qemu.convert(srcFile, destFile, null, null, null,
new QemuImageOptions(srcFile.getFormat(), srcFile.getFileName(), null),
Review Comment:
[nitpick] Extra whitespace between 'null,' parameters. Should have
consistent single-space separation between parameters.
```suggestion
qemu.convert(srcFile, destFile, null, null,
null, new QemuImageOptions(srcFile.getFormat(), srcFile.getFileName(), null),
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java:
##########
@@ -272,7 +296,7 @@ public MigrationResponse migrateResources(Long
srcImgStoreId, Long destImgStoreI
}
if (storageCapacityBelowThreshold(storageCapacities,
destImgStoreId)) {
- storageCapacities = migrateAway(chosenFileForMigration,
storageCapacities, snapshotChains, childTemplates, srcDatastore,
destImgStoreId, executor, futures);
+ storageCapacities = migrateAway(chosenFileForMigration,
storageCapacities, snapshotChains, childTemplates, snapshotIdsToMigrate,
srcDatastore, destImgStoreId, executor, futures);
Review Comment:
[nitpick] Extra whitespace before 'snapshotIdsToMigrate' parameter. Should
have consistent single-space separation between parameters.
```suggestion
storageCapacities = migrateAway(chosenFileForMigration,
storageCapacities, snapshotChains, childTemplates, snapshotIdsToMigrate,
srcDatastore, destImgStoreId, executor, futures);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
