abh1sar opened a new pull request, #12193:
URL: https://github.com/apache/cloudstack/pull/12193
### Description
This PR introduces several configuration settings using which an operator
can mark certain cryptographic algorithms and parameters as excluded or
obsolete for VPN Customer Gateway creation for Site-to-Site VPN.
Cloud providers following modern security frameworks (e.g., ISO 27001/27017)
are required to enforce and communicate approved cryptographic standards.
CloudStack currently accepts several weak or deprecated algorithms without
guidance to users. This PR closes that gap by giving operators explicit control
over what is disallowed vs discouraged, improving security posture without
breaking existing deployments.
These settings are:
_1. vpn.customer.gateway.excluded.encryption.algorithms
2. vpn.customer.gateway.excluded.hashing.algorithms
3. vpn.customer.gateway.excluded.ike.versions
4. vpn.customer.gateway.excluded.dh.group
5. vpn.customer.gateway.obsolete.encryption.algorithms
6. vpn.customer.gateway.obsolete.hashing.algorithms
7. vpn.customer.gateway.obsolete.ike.versions
8. vpn.customer.gateway.obsolete.dh.group_
Details :
1. Excluded parameters are not shown to the Users in the Create and Update
VPN Customer Gateway forms.
2. Obsolete parameters are shown with a warning
3. If a VPN gateway is already using an excluded or obsolete parameter:
a. A warning icon is displayed near to it's name with a message to
change the obsolete parameter.
b. The Update VPN gateway form shows the setting with a warning to
change it.
4. listVpnCustomerGateways api returns two new fields
`containsobsoleteparameters` and `containsexcludedparameters` which tells
whether an existing gateway is containing obsolete or excluded.
5. A new field in the listCapabilities API response contains the list
excluded and obsolete vpn customer gateway parameters, only if set.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
<img width="555" height="1265" alt="Screenshot 2025-12-01 at 1 55 23 PM"
src="https://github.com/user-attachments/assets/40b1b00c-8852-405d-ac52-e056d2a9af04";
/>
<img width="556" height="1295" alt="Screenshot 2025-12-01 at 1 55 08 PM"
src="https://github.com/user-attachments/assets/0f34bfdc-1e90-4189-af69-156384516f4f";
/>
<img width="1374" height="301" alt="Screenshot 2025-12-01 at 1 54 25 PM"
src="https://github.com/user-attachments/assets/57d87763-f21a-40f7-bd7b-3b616fc55f7c";
/>
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
