JoaoJandre commented on code in PR #9132:
URL: https://github.com/apache/cloudstack/pull/9132#discussion_r2613844140
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/internallb/StopInternalLBVMCmd.java:
##########
@@ -105,7 +105,7 @@ public boolean isForced() {
@Override
public void execute() throws ConcurrentOperationException,
ResourceUnavailableException {
- CallContext.current().setEventDetails("Internal lb vm Id: " + getId());
+ CallContext.current().setEventDetails("Internal lb VM Id: " + getId());
Review Comment:
```suggestion
CallContext.current().setEventDetails("Internal lb VM ID: " +
getId());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/RebootSystemVmCmd.java:
##########
@@ -105,7 +105,7 @@ public boolean isForced() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java:
##########
@@ -98,7 +98,7 @@ public long getEntityOwnerId() {
@Override
public void execute() {
- CallContext.current().setEventDetails("SystemVm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("SystemVM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("SystemVM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateDefaultNicForVMCmd.java:
##########
@@ -104,7 +104,7 @@ public long getEntityOwnerId() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Nic Id: " +
this._uuidMgr.getUuid(Nic.class, getNicId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Nic Id: " +
this._uuidMgr.getUuid(Nic.class, getNicId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Nic Id: " +
this._uuidMgr.getUuid(Nic.class, getNicId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/DestroySystemVmCmd.java:
##########
@@ -91,7 +91,7 @@ public Long getApiResourceId() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/StartVMCmd.java:
##########
@@ -177,7 +177,7 @@ public Long getApiResourceId() {
@Override
public void execute() {
try {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java:
##########
@@ -103,7 +103,7 @@ public long getEntityOwnerId() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Nic Id: " +
this._uuidMgr.getUuid(Nic.class, getNicId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Nic Id: " +
this._uuidMgr.getUuid(Nic.class, getNicId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Nic Id: " +
this._uuidMgr.getUuid(Nic.class, getNicId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/StopVMCmd.java:
##########
@@ -115,7 +115,7 @@ public boolean isForced() {
@Override
public void execute() throws ServerApiException,
ConcurrentOperationException {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ResetVMUserDataCmd.java:
##########
@@ -143,7 +143,7 @@ public Long getApiResourceId() {
@Override
public void execute() throws ResourceUnavailableException,
InsufficientCapacityException {
- CallContext.current().setEventDetails("Vm Id: " + getId());
+ CallContext.current().setEventDetails("VM Id: " + getId());
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " + getId());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DestroyVMCmd.java:
##########
@@ -131,7 +131,7 @@ public Long getApiResourceId() {
@Override
public void execute() throws ResourceUnavailableException,
ConcurrentOperationException {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java:
##########
@@ -97,7 +97,7 @@ public String getEventDescription() {
public void execute() throws ResourceUnavailableException,
InsufficientCapacityException, ServerApiException, ConcurrentOperationException,
ResourceAllocationException {
UserVm result;
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java:
##########
@@ -300,7 +300,7 @@ public long getEntityOwnerId() {
@Override
public void execute() throws ResourceUnavailableException,
InsufficientCapacityException, ServerApiException {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/StartSystemVMCmd.java:
##########
@@ -102,7 +102,7 @@ public Long getApiResourceId() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/StopSystemVmCmd.java:
##########
@@ -108,7 +108,7 @@ public boolean isForced() {
@Override
public void execute() throws ResourceUnavailableException,
ConcurrentOperationException {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ResetVMSSHKeyCmd.java:
##########
@@ -152,7 +152,7 @@ public Long getApiResourceId() {
@Override
public void execute() throws ResourceUnavailableException,
InsufficientCapacityException {
- CallContext.current().setEventDetails("Vm Id: " + getId());
+ CallContext.current().setEventDetails("VM Id: " + getId());
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " + getId());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/RebootVMCmd.java:
##########
@@ -115,7 +115,7 @@ public Long getApiResourceId() {
@Override
public void execute() throws ResourceUnavailableException,
InsufficientCapacityException, ResourceAllocationException {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ResetVMPasswordCmd.java:
##########
@@ -124,7 +124,7 @@ public void execute() throws ResourceUnavailableException,
InsufficientCapacityE
} else {
logger.debug(String.format("Resetting VM [%s] password to password
defined by user.", vm.getUuid()));
}
- CallContext.current().setEventDetails("Vm Id: " + getId());
+ CallContext.current().setEventDetails("VM Id: " + getId());
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " + getId());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/iso/AttachIsoCmd.java:
##########
@@ -114,7 +114,7 @@ public ApiCommandResourceType getApiResourceType() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
getVirtualMachineId() + " ISO ID: " + getId());
+ CallContext.current().setEventDetails("VM Id: " +
getVirtualMachineId() + " ISO ID: " + getId());
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
getVirtualMachineId() + " ISO ID: " + getId());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java:
##########
@@ -91,7 +91,7 @@ public boolean isVolumeOrSnapshotProvided() {
public void execute() {
UserVm result;
- CallContext.current().setEventDetails("Vm Id: " + getEntityUuid());
+ CallContext.current().setEventDetails("VM Id: " + getEntityUuid());
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " + getEntityUuid());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/AddNicToVMCmd.java:
##########
@@ -167,7 +167,7 @@ public ApiCommandResourceType getApiResourceType() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Network Id: " +
this._uuidMgr.getUuid(Network.class, getNetworkId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Network Id: " +
this._uuidMgr.getUuid(Network.class, getNetworkId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getVmId()) + " Network Id: " +
this._uuidMgr.getUuid(Network.class, getNetworkId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ExpungeVMCmd.java:
##########
@@ -96,7 +96,7 @@ public Long getApiResourceId() {
@Override
public void execute() throws ResourceUnavailableException,
ConcurrentOperationException {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java:
##########
@@ -87,7 +87,7 @@ public long getEntityOwnerId() {
@Override
public void execute() {
- CallContext.current().setEventDetails("Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
+ CallContext.current().setEventDetails("VM Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
Review Comment:
```suggestion
CallContext.current().setEventDetails("VM ID: " +
this._uuidMgr.getUuid(VirtualMachine.class, getId()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
