abh1sar commented on code in PR #12194:
URL: https://github.com/apache/cloudstack/pull/12194#discussion_r2625840098
##########
api/src/main/java/org/apache/cloudstack/api/response/BackupOfferingResponse.java:
##########
@@ -62,11 +62,13 @@ public class BackupOfferingResponse extends BaseResponse {
private String zoneName;
@SerializedName(ApiConstants.DOMAIN_ID)
- @Param(description = "the domain ID(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.")
+ @Param(description = "the domain ID(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.",
Review Comment:
this disk offering -> this backup offering
"Ignore this information.." thus should not be here, right?
##########
api/src/main/java/org/apache/cloudstack/api/response/BackupOfferingResponse.java:
##########
@@ -62,11 +62,13 @@ public class BackupOfferingResponse extends BaseResponse {
private String zoneName;
@SerializedName(ApiConstants.DOMAIN_ID)
- @Param(description = "the domain ID(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.")
+ @Param(description = "the domain ID(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.",
+ since = "4.23.0")
private String domainId;
@SerializedName(ApiConstants.DOMAIN)
- @Param(description = "the domain name(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.")
+ @Param(description = "the domain name(s) this disk offering belongs to.
Ignore this information as it is not currently applicable.",
Review Comment:
Same here
##########
engine/schema/src/main/java/org/apache/cloudstack/backup/dao/BackupOfferingDetailsDaoImpl.java:
##########
@@ -73,4 +76,26 @@ public List<Long> findOfferingIdsByDomainIds(List<Long>
domainIds) {
Object[] dIds = domainIds.stream().map(s ->
String.valueOf(s)).collect(Collectors.toList()).toArray();
return findResourceIdsByNameAndValueIn("domainid", dIds);
}
+
+ @DB
+ @Override
+ public void updateBackupOfferingDetails(long backupOfferingId, List<Long>
filteredDomainIds) {
Review Comment:
nit: rename to updateBackupOfferingDomainIdsDetails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
