sudo87 commented on code in PR #12294:
URL: https://github.com/apache/cloudstack/pull/12294#discussion_r2644963568
##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -2847,6 +2862,8 @@ public UserAccount authenticateUser(final String
username, final String password
logger.debug(String.format("User: %s in domain %d has
successfully logged in, auth time duration - %d ms", username, domainId,
validUserLastAuthTimeDurationInMs));
}
+ user.setDetails(_userDetailsDao.listDetailsKeyPairs(user.getId()));
Review Comment:
loginUser method in ApiServer.java fetches userAccount will need userDetails
to set passwordChangeRequired if its true.
authenticateUser method doesn't add details in the userAccount, it needs to
be included.
```
if (userId != null) {
userAcct = accountMgr.getUserAccountById(userId);
} else {
userAcct = accountMgr.authenticateUser(username, password, domainId,
loginIpAddress, requestParameters);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
