DaanHoogland commented on code in PR #12332:
URL: https://github.com/apache/cloudstack/pull/12332#discussion_r2645069687
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPrepareForMigrationCommandWrapper.java:
##########
@@ -83,6 +84,9 @@ public Answer execute(final PrepareForMigrationCommand
command, final LibvirtCom
if (interfaceDef != null && interfaceDef.getNetType() ==
GuestNetType.VHOSTUSER) {
DpdkTO to = new DpdkTO(interfaceDef.getDpdkOvsPath(),
interfaceDef.getDpdkSourcePort(), interfaceDef.getInterfaceMode());
dpdkInterfaceMapping.put(nic.getMac(), to);
+ if (logger.isDebugEnabled()) {
+ logger.debug("Configured DPDK interface for VM {}",
vm.getName());
+ }
Review Comment:
i don’t think this condition is needed (with log4j2 anymore)
```suggestion
logger.debug("Configured DPDK interface for VM {}",
vm.getName());
```
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -7189,6 +7189,9 @@ public VirtualMachine migrateVirtualMachine(Long vmId,
Host destinationHost) thr
throw new CloudRuntimeException("Unable to find suitable
destination to migrate VM " + vm.getInstanceName());
}
+ if (logger.isInfoEnabled()) {
+ logger.info("Starting migration of VM {} from host {} to host {}
", vm.getInstanceName(), srcHostId, dest.getHost().getId());
+ }
Review Comment:
```suggestion
logger.info("Starting migration of VM {} from host {} to host {} ",
vm.getInstanceName(), srcHostId, dest.getHost().getId());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
