sureshanaparti commented on code in PR #12335:
URL: https://github.com/apache/cloudstack/pull/12335#discussion_r2652173117
##########
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java:
##########
@@ -852,16 +848,42 @@ public boolean createFullClone(String cloneName,
ManagedObjectReference morFolde
setDiskProvisioningType(relocSpec, morDs, diskProvisioningType);
- ManagedObjectReference morTask =
_context.getService().cloneVMTask(_mor, morFolder, cloneName, cloneSpec);
+ return cloneVM(cloneName, morFolder, cloneSpec);
+ }
+ private boolean cloneVMTask(String cloneName, ManagedObjectReference
morFolder, VirtualMachineCloneSpec cloneSpec) throws Exception {
+ ManagedObjectReference morTask =
_context.getService().cloneVMTask(_mor, morFolder, cloneName, cloneSpec);
boolean result = _context.getVimClient().waitForTask(morTask);
if (result) {
_context.waitForTaskProgressDone(morTask);
return true;
- } else {
- logger.error("VMware cloneVM_Task failed due to " +
TaskMO.getTaskFailureInfo(_context, morTask));
}
+ logger.error("VMware cloneVM_Task failed due to {}",
TaskMO.getTaskFailureInfo(_context, morTask));
+ return false;
+ }
+
+ private boolean cloneVM(final String cloneName, final
ManagedObjectReference morFolder, final VirtualMachineCloneSpec cloneSpec)
throws Exception {
+ final int retry = 20;
+ int retryAttempt = 0;
+ while (++retryAttempt <= retry) {
+ try {
+ logger.debug("Cloning VM {}, attempt #{}", cloneName,
retryAttempt);
+ return cloneVMTask(cloneName, morFolder, cloneSpec);
+ } catch (Exception e) {
+ logger.info("Got exception while cloning VM {}", cloneName, e);
+ if (e.getMessage() != null && e.getMessage().contains("Unable
to access file")) {
+ logger.debug("Failed to clone VM {}. Retrying", cloneName);
+ try {
+ Thread.sleep(1000);
+ } catch (InterruptedException ie) {
+ logger.debug("Waiting to clone VM {} been interrupted:
", cloneName);
Review Comment:
that's for sleep call @abh1sar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
