DaanHoogland commented on issue #12314: URL: https://github.com/apache/cloudstack/issues/12314#issuecomment-3702339679
> The DB should show the state=Disabled or any other word that the community thing is acceptable, this is to be consistent. I don't see is affecting the Operations we have - I am not sure if there is a tag for "cosmetic", "db-consistency" I do not agree with this statement. The state of the offering is not disabled, it was enabled last before being removed. there is no state for removed anymore than for “Removing”, “Creating, “Created” or any of the other states some other DB objects may have. The state does not reflect any removal and is only valid for records not being marked as removed. the statement > mysql> select id,name,uuid,unique_name,created, removed,state,guest_type from network_offerings where state="Disabled or Removed"; does not make sense, the clause 'state="Disabled or Removed”’ is not a valid clause. 'state=“Disabled”’ would be and it would show all currently “Disabled” offerings, including those that are removed. 'state=“Enabled”’ would show all enabled offering even when removed. I know for some entities there is a state removed and not making the state be removed when setting the field removed for those entities would be an inconsistency but for these offerings it would imply these where disabled before removing, which is not true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
