DaanHoogland commented on code in PR #11350:
URL: https://github.com/apache/cloudstack/pull/11350#discussion_r2671767334
##########
api/src/main/java/org/apache/cloudstack/alert/AlertService.java:
##########
@@ -71,8 +71,8 @@ private AlertType(short type, String name, boolean isDefault)
{
public static final AlertType ALERT_TYPE_HA_ACTION = new
AlertType((short)30, "ALERT.HA.ACTION", true);
public static final AlertType ALERT_TYPE_CA_CERT = new
AlertType((short)31, "ALERT.CA.CERT", true);
public static final AlertType ALERT_TYPE_VM_SNAPSHOT = new
AlertType((short)32, "ALERT.VM.SNAPSHOT", true);
- public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new
AlertType((short)32, "ALERT.VR.PUBLIC.IFACE.MTU", true);
- public static final AlertType ALERT_TYPE_VR_PRIVATE_IFACE_MTU = new
AlertType((short)32, "ALERT.VR.PRIVATE.IFACE.MTU", true);
+ public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new
AlertType((short)33, "ALERT.VR.PUBLIC.IFACE.MTU", true);
Review Comment:
ok, could be done (maybe). I just wonder if this is worth the trouble.
Alerts are just that ; a one of alerting of the operator to signal the system
needs attention. I am not sure maintaining old alerts is a worthwhile endeavour.
Also, we would need to be deadsure the conversion is correct and complete
for it to make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
