weizhouapache commented on code in PR #12410:
URL: https://github.com/apache/cloudstack/pull/12410#discussion_r2685408871
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -351,6 +351,15 @@ public enum Config {
ConfigKey.Kind.CSV,
null),
+ DhcpLeaseTimeout(
+ "Network",
+ ManagementServer.class,
+ Integer.class,
+ "dhcp.lease.timeout",
+ "0",
+ "DHCP lease time in seconds for VMs. Use 0 for infinite lease time
(default). A non-zero value sets the lease duration in seconds.",
+ null),
Review Comment:
+1 with ConfigKey
may refer to
https://github.com/apache/cloudstack/blob/main/engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
which scope is best ? Global, Zone or so? @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
