nvazquez commented on code in PR #11947:
URL: https://github.com/apache/cloudstack/pull/11947#discussion_r2691458274
##########
utils/src/main/java/com/cloud/utils/script/Script.java:
##########
@@ -236,6 +237,14 @@ static String stackTraceAsString(Throwable throwable) {
}
public String execute(OutputInterpreter interpreter) {
+ return execute(interpreter, null);
+ }
+
+ public String execute(OutputInterpreter interpreter, String[] environment)
{
+ return executeInternal(interpreter, environment);
+ }
+
+ public String executeInternal(OutputInterpreter interpreter, String[]
environment) {
Review Comment:
@shwstppr @DaanHoogland I would prefer keeping it like this as
script.execute(outputLogger); has 73 usages which we'll need passing null as
the second parameter. I think keeping it like this it cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
