Damans227 opened a new pull request, #12426: URL: https://github.com/apache/cloudstack/pull/12426
### Description This PR fixes an issue where the SystemVM template is not automatically downloaded to S3 secondary storage when adding it to a CloudStack zone. **Root Cause:** S3 stores use `REGION` scope but `DefaultEndPointSelector` only returned `LocalHostEndpoint` for `ZONE` scope, so no endpoint was found to download the SystemVM template. **Fix:** Allow `LocalHostEndpoint` to handle SYSTEM template downloads for `REGION`-scoped stores, plus added null checks for S3 stores without URLs and enabled path-style access for S3-compatible storage. Fixes: #9002 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [x] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): **Broken:** <img width="2134" height="465" alt="image" src="https://github.com/user-attachments/assets/e8334b38-1649-46ff-b3ca-2e4f60c70777"; /> **Fixed:** https://github.com/user-attachments/assets/c513f2bf-35f7-4452-aba4-31624200826e ### How Has This Been Tested? **Test Environment:** - CloudStack 4.20.3.0 - KVM hypervisor (Ubuntu 22.04) - MinIO S3-compatible storage **Test Steps:** 1. Started with a fresh CloudStack zone with no secondary storage configured 2. Added NFS staging store (required for S3) 3. Added S3 image store (MinIO) via UI 4. Verified SystemVM template automatically downloaded to S3 5. Verified SSVM booted successfully using the template from S3 6. Verified Console Proxy VM also booted successfully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
