Copilot commented on code in PR #12425:
URL: https://github.com/apache/cloudstack/pull/12425#discussion_r2693069645
##########
pom.xml:
##########
@@ -1094,15 +1095,25 @@
<configuration>
<source>${cs.jdk.version}</source>
<target>${cs.jdk.version}</target>
- <fork>true</fork>
- <meminitial>128m</meminitial>
- <maxmem>512m</maxmem>
+ <encoding>UTF-8</encoding>
Review Comment:
The encoding configuration was added explicitly, which is good practice.
However, this duplicates the project-level property
'project.build.sourceEncoding' already set to UTF-8 at line 50. While not
harmful, it's redundant since Maven uses the project property by default.
```suggestion
```
##########
.github/workflows/errorprone.yml:
##########
@@ -0,0 +1,122 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Error Prone Analysis
+
+on:
+ push:
+ branches: [ main, add-errorprone ]
+ pull_request:
+ branches: [ main, '4.20' ]
Review Comment:
The workflow includes temporary test branches ('add-errorprone' and '4.20')
that should be removed before merging to main. According to the PR description,
these were added temporarily to test the workflow.
```suggestion
branches: [ main ]
pull_request:
branches: [ main ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
