nvazquez opened a new pull request, #12431: URL: https://github.com/apache/cloudstack/pull/12431
### Description This PR fixes the updateNetworkOffering API in case the `domainid` parameter exceeds 255 characters (default String value size), by increasing the parameter size to 4096 characters. UUIDs are 36 characters strings, the PR increases the possible domains from ~7 domains to +100 domains, useful for large environments. Before the fix (tested with 10 domains): ```` (localcloud) 🐱 > update networkoffering id=3e34e242-ba35-4a69-a42c-840b582b6ae2 domainid=014c077e-7607-475f-a8c0-e5c09d2d1dfd,10c152f5-6ee6-45ff-88ec-0852d084c5b5,51134a69-dc61-41cc-8c36-8b7f0f2ede12,684d20fe-491b-4667-9c51-4c258d9fd4af,7b42bcde-7348-41e9-99fc-6a86941d12fc,aa330251-65a5-4da1-afe7-6610d50545ef,dc28b4f9-f08a-440a-835a-9ef7910922fa,e049720c-c73a-482e-830e-3a16ab19f992,e42bb23f-026f-4d7e-bbc2-19d02fec0264,f17f96ef-749c-46e8-80b9-36cbbef65eef 🙈 Error: (HTTP 431, error code 9999) Unable to execute API command updatenetworkoffering due to invalid value. Value greater than max allowed length 255 for param: domainIds ```` After the fix (same operation) succeeds Fixes: #12399 <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
