RosiKyu commented on PR #11889:
URL: https://github.com/apache/cloudstack/pull/11889#issuecomment-3768147373
### WIP
### Test Case 1: Admin creates SLA backup offering
(userDrivenBackupsAllowed=false)
**Objective**: Verify that an administrator can successfully create an
SLA-type backup offering with `allowuserdrivenbackups=false`.
**Environment:**
- CloudStack Management Server:
`ref-trl-10594-k-Mol9-rositsa-kyuchukova-mgmt1`
- Zone: `ref-trl-10594-k-Mol9-rositsa-kyuchukova` (ID:
`bd294515-c45a-4223-80d2-d687a3cc4818`)
- Backup Provider: `dummy`
**Test Steps:**
1. As admin, import a backup offering with `allowuserdrivenbackups=false`
2. Verify the offering is created and listed
**Expected Result:** SLA backup offering is created successfully with
`allowuserdrivenbackups=false`
**Evidence:**
1. Created SLA backup offering:
```
(localcloud) 🐱 > import backupoffering externalid=gold-policy
zoneid=bd294515-c45a-4223-80d2-d687a3cc4818 name="SLA-Gold-Backup"
description="SLA managed backup - no user control" allowuserdrivenbackups=false
{
"backupoffering": {
"allowuserdrivenbackups": false,
"created": "2026-01-19T12:34:14+0000",
"description": "SLA managed backup - no user control",
"externalid": "gold-policy",
"id": "21daf30a-d8cf-4eb1-9d47-d0e77f21bba0",
"name": "SLA-Gold-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
}
}
```
2. Verified offering exists:
```
(localcloud) 🐱 > list backupofferings listall=true
{
"backupoffering": [
{
"allowuserdrivenbackups": false,
"created": "2026-01-19T12:34:14+0000",
"description": "SLA managed backup - no user control",
"externalid": "gold-policy",
"id": "21daf30a-d8cf-4eb1-9d47-d0e77f21bba0",
"name": "SLA-Gold-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
}
],
"count": 1
}
```
**Test Result:** **PASS** - Admin successfully created SLA backup offering
with `allowuserdrivenbackups=false`
### Test Case 2: Admin creates ADHOC backup offering
(userDrivenBackupsAllowed=true)
**Objective**: Verify that an administrator can successfully create an
ADHOC-type backup offering with `allowuserdrivenbackups=true`.
**Environment:**
- CloudStack Management Server:
`ref-trl-10594-k-Mol9-rositsa-kyuchukova-mgmt1`
- Zone: `ref-trl-10594-k-Mol9-rositsa-kyuchukova` (ID:
`bd294515-c45a-4223-80d2-d687a3cc4818`)
- Backup Provider: `dummy`
**Test Steps:**
1. As admin, import a backup offering with `allowuserdrivenbackups=true`
2. Verify both SLA and ADHOC offerings are listed
**Expected Result:** ADHOC backup offering is created successfully with
`allowuserdrivenbackups=true`
**Evidence:**
1. Created ADHOC backup offering:
```
(localcloud) 🐱 > import backupoffering externalid=silver-policy
zoneid=bd294515-c45a-4223-80d2-d687a3cc4818 name="ADHOC-Silver-Backup"
description="User-controlled backup - can trigger manually"
allowuserdrivenbackups=true
{
"backupoffering": {
"allowuserdrivenbackups": true,
"created": "2026-01-19T12:36:52+0000",
"description": "User-controlled backup - can trigger manually",
"externalid": "silver-policy",
"id": "a8cebf94-a04b-4b02-aec0-816c0f1f2439",
"name": "ADHOC-Silver-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
}
}
```
2. Verified both offerings exist:
```
(localcloud) 🐱 > list backupofferings listall=true
{
"backupoffering": [
{
"allowuserdrivenbackups": false,
"created": "2026-01-19T12:34:14+0000",
"description": "SLA managed backup - no user control",
"externalid": "gold-policy",
"id": "21daf30a-d8cf-4eb1-9d47-d0e77f21bba0",
"name": "SLA-Gold-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
},
{
"allowuserdrivenbackups": true,
"created": "2026-01-19T12:36:52+0000",
"description": "User-controlled backup - can trigger manually",
"externalid": "silver-policy",
"id": "a8cebf94-a04b-4b02-aec0-816c0f1f2439",
"name": "ADHOC-Silver-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
}
],
"count": 2
}
```
**Test Result:** **PASS** - Admin successfully created ADHOC backup offering
with `allowuserdrivenbackups=true`. Both SLA and ADHOC offerings are now
available.
```
### Test Case 3: Regular user can list both SLA and ADHOC backup offerings
**Objective**: Verify that a non-admin user can list both SLA
(`allowuserdrivenbackups=false`) and ADHOC (`allowuserdrivenbackups=true`)
backup offerings after the fix.
**Environment:**
- CloudStack Management Server:
`ref-trl-10594-k-Mol9-rositsa-kyuchukova-mgmt1`
- Zone: `ref-trl-10594-k-Mol9-rositsa-kyuchukova`
- Backup Provider: `dummy`
- Test User: `ACSUser` (accounttype=0, regular user)
**Preconditions:**
- SLA offering `SLA-Gold-Backup` exists with `allowuserdrivenbackups=false`
- ADHOC offering `ADHOC-Silver-Backup` exists with
`allowuserdrivenbackups=true`
**Test Steps:**
1. Switch to regular user profile (`acsuser`)
2. List backup offerings
**Expected Result:** Regular user can see BOTH SLA and ADHOC backup offerings
**Evidence:**
```
(acsuser) 🐱 > list backupofferings
{
"backupoffering": [
{
"allowuserdrivenbackups": false,
"created": "2026-01-19T12:34:14+0000",
"description": "SLA managed backup - no user control",
"externalid": "gold-policy",
"id": "21daf30a-d8cf-4eb1-9d47-d0e77f21bba0",
"name": "SLA-Gold-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
},
{
"allowuserdrivenbackups": true,
"created": "2026-01-19T12:36:52+0000",
"description": "User-controlled backup - can trigger manually",
"externalid": "silver-policy",
"id": "a8cebf94-a04b-4b02-aec0-816c0f1f2439",
"name": "ADHOC-Silver-Backup",
"provider": "dummy",
"zoneid": "bd294515-c45a-4223-80d2-d687a3cc4818",
"zonename": "ref-trl-10594-k-Mol9-rositsa-kyuchukova"
}
],
"count": 2
}
```
**Test Result:** **PASS** - Regular user can now list both SLA and ADHOC
backup offerings. This confirms PR #11889 fixes the bug reported in #11878.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
