DaanHoogland commented on PR #12144:
URL: https://github.com/apache/cloudstack/pull/12144#issuecomment-3771630585

   the el compile gives
   ```
   10:26:59 [INFO] Running 
org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest
   10:27:03 [ERROR] Tests run: 34, Failures: 0, Errors: 1, Skipped: 0, Time 
elapsed: 4.786 s <<< FAILURE! - in 
org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest
   10:27:03 [ERROR] unnecessary Mockito 
stubbings(org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest)
  Time elapsed: 0.03 s  <<< ERROR!
   10:27:03 org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
   10:27:03 
   10:27:03 Unnecessary stubbings detected in test class: 
ManagementServerMaintenanceManagerImplTest
   10:27:03 Clean & maintainable test code requires zero unnecessary code.
   10:27:03 Following stubbings are unnecessary (click to navigate to relevant 
line of code):
   10:27:03   1. -> at 
org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:324)
   10:27:03   2. -> at 
org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromPreparingForMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:342)
   10:27:03 Please remove unnecessary stubbings or use 'lenient' strictness. 
More info: javadoc for UnnecessaryStubbingException class.
   10:27:03 
   10:27:04 [INFO] 
   10:27:04 [INFO] Results:
   10:27:04 [INFO] 
   10:27:04 [ERROR] Errors: 
   10:27:04 [ERROR]   ManagementServerMaintenanceManagerImplTest.unnecessary 
Mockito stubbings ? UnnecessaryStubbing
   10:27:04 [INFO] 
   10:27:04 [ERROR] Tests run: 34, Failures: 0, Errors: 1, Skipped: 0
   ```
   This might be due to a injected object no longer being called in a test. It 
is always an awkward issue to find. Can you help on this one @vishesh92 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to