saturn-amarbat commented on issue #12466: URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3782535323
Interesting catch on this filtering bug. Looking at the issue, it seems the keyword parameter is accepted by the API but not actually used in the search criteria implementation. A few thoughts for investigation: 1. The problem is likely in BackupManagerImpl.java where the search logic needs to check if `keyword` is provided and apply it to the name/description filtering 2. Similar list APIs in CloudStack probably handle this correctly - might be worth checking how `listServiceOfferings` or `listComputeOfferings` implement their keyword filtering for reference 3. The reproduction steps are clear - creating a test case with 3 offerings and verifying each keyword returns empty vs the expected filtered result would validate the fix Worth checking if this is just a missing null/empty check on the keyword parameter or if the filtering logic itself wasn't connected. The fact that other parameters work correctly suggests it's isolated to the keyword implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
