DaanHoogland commented on PR #12410: URL: https://github.com/apache/cloudstack/pull/12410#issuecomment-3783604753
@NVShawn , every other time we get an unnecessary stubbing error in unpredictable order in ``` 11:50:09 [INFO] Running org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest 11:50:09 [ERROR] Tests run: 34, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.196 s <<< FAILURE! - in org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest 11:50:12 [ERROR] unnecessary Mockito stubbings(org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest) Time elapsed: 0.019 s <<< ERROR! 11:50:12 org.mockito.exceptions.misusing.UnnecessaryStubbingException: 11:50:12 11:50:12 Unnecessary stubbings detected in test class: ManagementServerMaintenanceManagerImplTest 11:50:12 Clean & maintainable test code requires zero unnecessary code. 11:50:12 Following stubbings are unnecessary (click to navigate to relevant line of code): 11:50:12 1. -> at org.apache.cloudstack.maintenance.ManagementServerMaintenanceManagerImplTest.prepareForMaintenanceAndCancelFromPreparingForMaintenanceState(ManagementServerMaintenanceManagerImplTest.java:342) 11:50:12 Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class. 11:50:12 11:50:12 [INFO] 11:50:12 [INFO] Results: 11:50:12 [INFO] 11:50:12 [ERROR] Errors: 11:50:12 [ERROR] ManagementServerMaintenanceManagerImplTest.unnecessary Mockito stubbings ? UnnecessaryStubbing 11:50:12 [INFO] 11:50:12 [ERROR] Tests run: 34, Failures: 0, Errors: 1, Skipped: 0 ``` This time in the ubuntu build and last time in the EL build. I discussed quickly with @vishesh92 and it might be due to a timing issue that makes the stub being called sometimes and not at other times (due to your changes???). I think we need to fix the test to continue :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
