Imvedansh commented on PR #12380: URL: https://github.com/apache/cloudstack/pull/12380#issuecomment-3789945675
> > @abh1sar no. @Imvedansh I think there needs to be a switch element to toggle cleanup in the new form you added or are we considering the operator entering domain name as cleanup=true. Currently, we are simply passing cleanup=true on submit. (I ended up accidentally deleting a domain on QA env 🤦♂️ ) I'm not sure about this behaviour and it feels a bit confusing compared to the original UI. Others can share their opinion. > > The expected behavior of this PR is to allow deletion of a domain along with all associated accounts and sub-domains (including all resources) while showing any associated accounts and VM. > > --- This domain may contain accounts, users, or sub-domains. All of these must be removed before the domain can be deleted. This action cannot be undone.--- is the current verbiage for the form ,It should be more like All associated accounts WILL BE DELETED and to prevent any catastrophic and unintended action ,added the requirement to enter the name of domain. > > If a cleanup flag is added and not checked, the API would simply return an error, and it’s unclear if that would provide a good user experience. Another approach I can think of is to disable the input container till the cleanup flag is true. with a little more clear warning above which states this will remove all the associated accounts,vm etc. I feel this could be good to have maybe in future not a must have for now. > > Current solution make it very easy to see all the accounts and vm in single container of parent domain and extra check of entering the domain name their removes the scope of deleting the resources by mistake while keeping it simpler to do action. > > WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
