DaanHoogland commented on code in PR #10776:
URL: https://github.com/apache/cloudstack/pull/10776#discussion_r2063588123
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3556,7 +3556,8 @@ public void reallyRun() {
final List<Long> networkIds =
_networksDao.findNetworksToGarbageCollect();
final int netGcWait =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcWait.key()), 60);
- logger.info("NetworkGarbageCollector uses '{}' seconds for GC
interval.", netGcWait);
+ final int netGcInterval =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60);
Review Comment:
```suggestion
final int netGcInterval = NetworkGcInterval.value();
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3556,7 +3556,8 @@ public void reallyRun() {
final List<Long> networkIds =
_networksDao.findNetworksToGarbageCollect();
final int netGcWait =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcWait.key()), 60);
- logger.info("NetworkGarbageCollector uses '{}' seconds for GC
interval.", netGcWait);
+ final int netGcInterval =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60);
Review Comment:
```suggestion
final int netGcWait = NetworkGcWait.value();
final int netGcInterval = NetworkGcInterval.value();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
