vishesh92 commented on code in PR #11974:
URL: https://github.com/apache/cloudstack/pull/11974#discussion_r2735450546
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -2982,14 +2999,7 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd)
throws ResourceUnavailableEx
vmInstance.setDetails(details);
_vmDao.saveDetails(vmInstance);
}
- if (StringUtils.isNotBlank(extraConfig)) {
- if (EnableAdditionalVmConfig.valueIn(accountId)) {
- logger.info("Adding extra configuration to user vm: " +
vmInstance.getUuid());
- addExtraConfig(vmInstance, extraConfig);
- } else {
- throw new InvalidParameterValueException("attempted
setting extraconfig but enable.additional.vm.configuration is disabled");
- }
- }
+ updateVmExtraConfig(userVm, extraConfig, cleanupExtraConfig);
}
Review Comment:
@shwstppr Please check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
