Re: [PR] extensions: add sync, download functionalities [cloudstack]

[via GitHub]

shwstppr commented on PR #11814:
URL: https://github.com/apache/cloudstack/pull/11814#issuecomment-3827946666

   > @shwstppr this looks great. Got a chance to test, sync and downloads are 
working fine. Though link expiry does not seem to be working as expected. I've 
enabled this "extension.share.download.use.secondary.storage" and set 
"extension.share.link.validity.interval" to 30.
   > 
   > I've made 3 attempts of download, folders and the last file remains exists 
after expiry time
   > <img alt="Image" width="753" height="228" 
src="https://private-user-images.githubusercontent.com/3348673/542782301-1b4e8efb-704a-4328-b753-14e9f0304bb6.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk4NDAxMTEsIm5iZiI6MTc2OTgzOTgxMSwicGF0aCI6Ii8zMzQ4NjczLzU0Mjc4MjMwMS0xYjRlOGVmYi03MDRhLTQzMjgtYjc1My0xNGU5ZjAzMDRiYjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDEzMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMzFUMDYxMDExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGQ2OTYzMTQ4Y2M2ZTUzN2QyMWZhNDQ5M2JkMGI4MjhiZWQ3NTYzNDFjM2VlMzVlMjJjMDUyNzY5ZDk1NmI1YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.LBJfByps0oLVvGJJGRqnh0x-lmQmsCB3QeYXyqr_p30";>
   
   @harikrishna-patnala this is a generic issue with download url cleanup on 
SSVM. While the symlink was removed, temp directory was not getting removed.
   ```
   2026-01-31T07:36:09,043 DEBUG [cloud.agent.Agent] 
(AgentRequest-Handler-5:[]) Request:Seq 4-7227995926952935435:  { Cmd , MgmtId: 
90520731363323, via: 4, Ver: v1, Flags: 100111, 
[{"com.cloud.agent.api.storage.DeleteEntityDownloadURLCommand":{"path":"volumes/2/4/97b241b4-4d31-469f-b4a4-a2fcab2606ff.qcow2","extractUrl":"http://172.120.1.2/userdata/88a99588-c0e0-4691-96c7-c7e6534d9fbe/t-dd.qcow2","type":"VOLUME","parentPath":"c794fe3b-bedb-3e8e-a5c6-c5a2b28a2065","accountId":"0","wait":"0","bypassHostMaintenance":"false"}}]
 }
   2026-01-31T07:36:09,044 DEBUG [cloud.agent.Agent] 
(AgentRequest-Handler-5:[]) Processing command: 
com.cloud.agent.api.storage.DeleteEntityDownloadURLCommand
   2026-01-31T07:36:09,044 DEBUG [storage.resource.NfsSecondaryStorageResource] 
(AgentRequest-Handler-5:[]) Executing command "DeleteEntityDownloadURLCommand" 
[{"path":"volumes/2/4/97b241b4-4d31-469f-b4a4-a2fcab2606ff.qcow2","extractUrl":"http://172.120.1.2/userdata/88a99588-c0e0-4691-96c7-c7e6534d9fbe/t-dd.qcow2","type":"VOLUME","parentPath":"c794fe3b-bedb-3e8e-a5c6-c5a2b28a2065","accountId":0,"contextMap":{},"wait":0,"bypassHostMaintenance":false}].
   2026-01-31T07:36:09,044 WARN  [storage.template.UploadManagerImpl] 
(AgentRequest-Handler-5:[]) handleDeleteEntityDownloadURLCommand 
Path:volumes/2/4/97b241b4-4d31-469f-b4a4-a2fcab2606ff.qcow2 Type:VOLUME
   2026-01-31T07:36:09,045 DEBUG [storage.template.UploadManagerImpl] 
(AgentRequest-Handler-5:[]) Executing command [/bin/bash -c unlink 
/var/www/html/userdata/88a99588-c0e0-4691-96c7-c7e6534d9fbe/t-dd.qcow2 ].
   2026-01-31T07:36:09,054 DEBUG [storage.template.UploadManagerImpl] 
(AgentRequest-Handler-5:[]) Successfully executed process [5938] for command 
[/bin/bash -c unlink 
/var/www/html/userdata/88a99588-c0e0-4691-96c7-c7e6534d9fbe/t-dd.qcow2 ].
   2026-01-31T07:36:09,054 WARN  [storage.template.UploadManagerImpl] 
(AgentRequest-Handler-5:[]) Deleted volume 
/mnt/SecStorage/c794fe3b-bedb-3e8e-a5c6-c5a2b28a2065/volumes/2/4/97b241b4-4d31-469f-b4a4-a2fcab2606ff.qcow2
   2026-01-31T07:36:09,055 DEBUG [storage.template.UploadManagerImpl] 
(AgentRequest-Handler-5:[]) Executing command [/bin/bash -c rm -rf 
/mnt/SecStorage/c794fe3b-bedb-3e8e-a5c6-c5a2b28a2065/volumes/2/4/97b241b4-4d31-469f-b4a4-a2fcab2606ff.qcow2
 ].
   2026-01-31T07:36:09,063 DEBUG [storage.template.UploadManagerImpl] 
(AgentRequest-Handler-5:[]) Successfully executed process [5939] for command 
[/bin/bash -c rm -rf 
/mnt/SecStorage/c794fe3b-bedb-3e8e-a5c6-c5a2b28a2065/volumes/2/4/97b241b4-4d31-469f-b4a4-a2fcab2606ff.qcow2
 ].
   2026-01-31T07:36:09,063 DEBUG [cloud.agent.Agent] 
(AgentRequest-Handler-5:[]) Seq 4-7227995926952935435:  { Ans: , MgmtId: 
90520731363323, via: 4, Ver: v1, Flags: 110, 
[{"com.cloud.agent.api.Answer":{"result":"true","details":"","wait":"0","bypassHostMaintenance":"false"}}]
   
   
   root@s-2-VM:/var/www/html/userdata# ls -lrt
   total 20
   drwxr-xr-x 2 www-data www-data 4096 Jan 31 06:08 
9142b6e3-f6c6-48de-86b6-6003eb147d2c
   drwxr-xr-x 2 www-data www-data 4096 Jan 31 06:10 
85378760-8b68-4c60-81fc-11ddbe59fd85
   drwxr-xr-x 2 www-data www-data 4096 Jan 31 06:28 
a3276a6b-03aa-44d0-aeef-183da3b214c4
   drwxr-xr-x 2 www-data www-data 4096 Jan 31 06:35 
0cfcf0a0-58f8-471b-8864-9b8a2b754da3
   drwxr-xr-x 2 www-data www-data 4096 Jan 31 07:36 
88a99588-c0e0-4691-96c7-c7e6534d9fbe
   root@s-2-VM:/var/www/html/userdata# ls -lrt 
88a99588-c0e0-4691-96c7-c7e6534d9fbe
   total 0
   ```
   
   I've added a fix and created https://github.com/apache/cloudstack/pull/12562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org