Copilot commented on code in PR #12543:
URL: https://github.com/apache/cloudstack/pull/12543#discussion_r2751303099
##########
pom.xml:
##########
@@ -73,7 +73,7 @@
<cs.spotbugs.version>3.1.12</cs.spotbugs.version>
<cs.spotbugs-maven-plugin.version>3.1.12.2</cs.spotbugs-maven-plugin.version>
<cs.jar-plugin.version>3.2.0</cs.jar-plugin.version>
- <cs.pmd-plugin.version>3.12.0</cs.pmd-plugin.version>
+ <cs.pmd-plugin.version>3.28.0</cs.pmd-plugin.version>
Review Comment:
Updating maven-pmd-plugin to 3.28.0 upgrades the underlying PMD engine (per
upstream release notes, PMD 7.x). Our configured ruleset `cloud-pmd.xml` (from
org.apache.cloudstack:checkstyle) references legacy rule paths like
`rulesets/java/basic.xml` (see
tools/checkstyle/src/main/resources/cloud-pmd.xml:34), which are not compatible
with PMD 7 rule category layouts. This will likely cause `mvn pmd:check` /
`cpd-check` to fail because the referenced rulesets can’t be resolved. Please
either update `cloud-pmd.xml` to PMD 7-compatible rule references
(category-based rulesets), or keep/pin the plugin/PMD version to one that
supports the current ruleset.
```suggestion
<cs.pmd-plugin.version>3.21.0</cs.pmd-plugin.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
