gruckbit opened a new pull request, #12567:
URL: https://github.com/apache/cloudstack/pull/12567
### Description
ACS has the global configuration `vm.network.throttling.rate` that allows
limiting the maximum bandwidth of the default NIC for end-user VMs when it is
not defined in compute offerings. However, currently, the setting is static,
implying the requirement of restarting the Management Servers after changing
its value.
Given this scenario, changes have been applied to make the configuration
dynamic. As a consequence, it is not required to restart the Management Servers
after each value update; the updated value is automatically considered in the
Apache CloudStack internal workflows.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
The default value of `vm.network.throttling.rate` is 200, and after changing
its value to 100 the VM's domain XML presented the following change:
Before:
```
virsh dumpxml 4 | grep "bandwidth" -A 2
<bandwidth>
<inbound average='25000' peak='25000'/>
<outbound average='25000' peak='25000'/>
</bandwidth>
<target dev='vnet10'/>
<model type='virtio'/>
```
After:
```
virsh dumpxml 5 | grep "bandwidth" -A 2
<bandwidth>
<inbound average='12500' peak='12500'/>
<outbound average='12500' peak='12500'/>
</bandwidth>
<target dev='vnet11'/>
<model type='virtio'/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
