JoaoJandre commented on code in PR #12597:
URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2769127335
##########
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java:
##########
@@ -151,6 +154,16 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
idStateNeqSearch.and(STATE, idStateNeqSearch.entity().getState(),
SearchCriteria.Op.NEQ);
idStateNeqSearch.done();
+ idStateNinSearch = createSearchBuilder();
+ idStateNinSearch.and(SNAPSHOT_ID,
idStateNinSearch.entity().getSnapshotId(), SearchCriteria.Op.EQ);
+ idStateNinSearch.and(STATE, idStateNinSearch.entity().getState(),
SearchCriteria.Op.NOTIN);
+ idStateNinSearch.done();
+
+ idEqRoleEqStateInSearch = createSearchBuilder();
+ idEqRoleEqStateInSearch.and(SNAPSHOT_ID,
idEqRoleEqStateInSearch.entity().getSnapshotId(), SearchCriteria.Op.EQ);
+ idEqRoleEqStateInSearch.and(STORE_ROLE,
idEqRoleEqStateInSearch.entity().getRole(), SearchCriteria.Op.EQ);
+ idEqRoleEqStateInSearch.and(STATE,
idEqRoleEqStateInSearch.entity().getState(), SearchCriteria.Op.IN);
Review Comment:
the `.create()` already calls `finalize()` (which is what `done()` does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
