winterhazel opened a new pull request, #12605:
URL: https://github.com/apache/cloudstack/pull/12605
### Description
This PR proposes unhiding `js.interpretation.enabled`. For reference
regarding why, see the discussion in #12523.
Also, the configuration was made dynamic, and some extra refactoring was
performed to organize the code.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### How Has This Been Tested?
1. I upgraded my environment to the new version, with the changes included,
and checked the database entry for `js.interpretation.enabled`.
- Before the changes:
```sql
MariaDB [cloud]> select * from configuration where name =
"js.interpretation.enabled";
+----------+----------+------------------+---------------------------+----------------------------------------------+------------------------------------------------------------------------------------------------------------+---------------+---------------------+------------+----------+-------------+--------+---------------------------+------+---------+-------+
| category | instance | component | name
| value | description
|
default_value | updated | is_dynamic | group_id | subgroup_id |
parent | display_text | kind | options | scope |
+----------+----------+------------------+---------------------------+----------------------------------------------+------------------------------------------------------------------------------------------------------------+---------------+---------------------+------------+----------+-------------+--------+---------------------------+------+---------+-------+
| Hidden | DEFAULT | ManagementServer | js.interpretation.enabled
| MQmVLZoL1kmmDHZR1YsoIgw0OuvMDdyTnU9y3FEUNDA= | Enable/Disable all JavaScript
interpretation related functionalities to create or update Javascript rules. |
false | 2026-01-23 11:09:12 | 0 | 1 | 1 |
NULL | Js interpretation enabled | NULL | NULL | 1 |
+----------+----------+------------------+---------------------------+----------------------------------------------+------------------------------------------------------------------------------------------------------------+---------------+---------------------+------------+----------+-------------+--------+---------------------------+------+---------+-------+
```
- In the logs:
```logs
2026-02-06 11:46:01,436 INFO [c.c.u.d.Upgrade42210to42300] (main:[])
(logid:) Updating setting 'js.interpretation.enabled' to decrypted value [true].
```
- After the changes:
```sql
MariaDB [cloud]> select * from configuration where name =
"js.interpretation.enabled";
+----------+----------+---------------+---------------------------+-------+-----------------------------------------------------------------------+---------------+---------------------+------------+----------+-------------+--------+---------------------------+------+---------+-------+
| category | instance | component | name |
value | description |
default_value | updated | is_dynamic | group_id | subgroup_id |
parent | display_text | kind | options | scope |
+----------+----------+---------------+---------------------------+-------+-----------------------------------------------------------------------+---------------+---------------------+------------+----------+-------------+--------+---------------------------+------+---------+-------+
| System | DEFAULT | JsInterpreter | js.interpretation.enabled |
true | Enable/disable all JavaScript interpretation related functionalities. |
false | 2026-02-06 11:45:28 | 1 | 1 | 1 |
NULL | Js interpretation enabled | NULL | NULL | 1 |
+----------+----------+---------------+---------------------------+-------+-----------------------------------------------------------------------+---------------+---------------------+------------+----------+-------------+--------+---------------------------+------+---------+-------+
```
2. I attempted to create heuristic rules, flexible tags, and Quota
activation rules. When the setting was disabled, I received an error informing
me that `js.interpretation.enabled` was disabled. When the setting was enabled,
I was able to create them successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
