Sinscerly commented on PR #12112: URL: https://github.com/apache/cloudstack/pull/12112#issuecomment-3907955088
> @Sinscerly , given comment [#12112 (comment)](https://github.com/apache/cloudstack/pull/12112#discussion_r2618715937), will you work on this more or do you want this merged as is? cc @kiranchavala @NuxRo @nvazquez @DaanHoogland I would need to revisit my dev environment and see if I can fix it to output more than the uttermost default metrics or if it's possible to give privately the metrics output for me to analyze if my thoughts were right or not about: > Well the item ItemHostCpu returns two different metrics: cloudstack_host_cpu_usage_mhz_total and cloudstack_host_cpu_usage_mhz_total_by_tag. I just made sure the correct help line is outputted for that metric. > So it seemed logical for me to also change that. Although I'm doubting it will work, as the toMetricsString is called after adding in the HELP and TYPE I see. Although this would require some bigger rework of adding metrics I think, split it up in separate items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
