sureshanaparti commented on code in PR #12666:
URL: https://github.com/apache/cloudstack/pull/12666#discussion_r2829424148
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -2093,8 +2093,25 @@ protected void rebaseSnapshot(SnapshotObjectTO
snapshotObjectTO, KVMStoragePool
QemuImg qemuImg = new QemuImg(wait);
qemuImg.rebase(snapshotFile, parentSnapshotFile,
PhysicalDiskFormat.QCOW2.toString(), false);
} catch (LibvirtException | QemuImgException e) {
- logger.error("Exception while rebasing incremental snapshot [{}]
due to: [{}].", snapshotName, e.getMessage(), e);
- throw new CloudRuntimeException(e);
+ if (!StringUtils.contains(e.getMessage(), "Is another process
using the image")) {
+ logger.error("Exception while rebasing incremental snapshot
[{}] due to: [{}].", snapshotName, e.getMessage(), e);
+ throw new CloudRuntimeException(e);
+ }
+ retryRebase(snapshotName, wait, e, snapshotFile,
parentSnapshotFile);
+ }
+ }
+
+ private void retryRebase(String snapshotName, int wait, Exception e,
QemuImgFile snapshotFile, QemuImgFile parentSnapshotFile) {
+ logger.warn("Libvirt still has not released the lock, will wait 60
seconds and try again later.");
+ try {
+ Thread.sleep(60*1000);
Review Comment:
is it required to keep this wait time configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
