robinkarlberg opened a new pull request, #12709:
URL: https://github.com/apache/cloudstack/pull/12709

   ### Description
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally 
changed. -->
   `RESTRICTED_TOKENS` is used to blacklist tokens for the JavaScript engine, 
used for rules etc. However, I saw that one of the entries `" javax"` has an 
accidental space in it, it should most likely be `"javax"`.
   
   As far as I understand, the typo does not lead to any security impact as the 
`--no-java` flag disables `javax` access, so that's why I'm creating an issue 
here on GitHub, and not a vulnerability disclosure. Consider this more of a 
little cleanup of the code.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- 
******************************************************************************* 
-->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE 
DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- 
******************************************************************************* 
-->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### How Has This Been Tested?
   
   Test still pass. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to