nvazquez opened a new pull request, #12487: URL: https://github.com/apache/cloudstack/pull/12487
### Description Documentation PR: https://github.com/apache/cloudstack-documentation/pull/631 This PR extends the conserve mode for VPCs tiers added on the previous PRs: https://github.com/apache/cloudstack/pull/8309, https://github.com/apache/cloudstack/pull/10744 by allowing: - If conserve_mode = true for network offering (for VPC tier): the public IPs can be used by multiple services (Lb, PortForwarding) - This behaviour already exists since 4.19 (except for Source NAT IP of the VPC) - With this PR, the public IP used for Source NAT can be reused for multiple services (it was previously restricted to Source NAT only) when VPC conserve_mode = true and network_offering for VPC tier = true This PR also introduces the following changes: - Introduce conserve mode for VPC offerings: - When a VPC is created from a VPC offering using conserve mode = true: public IP rules can be created on different VPC tiers (when conserve mode = false, the rules are restricted to a single VPC tier). - All the existing VPC offerings will keep conserve mode = false - VPC offerings can be created with conserve mode (default value = false on the VPC offering creation) Fixes: #8317 <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? - Create a VPC Offering with Conserve mode enabled selecting: - Conserve mode = True - Services: Dns, Dhcp, Vpn, UserData, StaticNat, SourceNat, NetworkACL, Portforwarding, Lb as VpcVirtualRouter - Create VPC selecting the previous VPC Offering - Create VPC tiers with the default isolated network offering for VPC and deploy VMs on each tier - Observe the Source NAT IP address can be used for multiple services, create different rules - Acquire new Public IP address and create rules across different VPC tiers for the same Public IP address #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
