Damans227 commented on code in PR #12702:
URL: https://github.com/apache/cloudstack/pull/12702#discussion_r2896450347
##########
ui/src/views/auth/Login.vue:
##########
@@ -150,9 +150,65 @@
</a-select>
</a-form-item>
</a-tab-pane>
+ <a-tab-pane key="oauth" :disabled="!socialLogin">
+ <template #tab>
+ <span>
+ <img src="/assets/github.svg" style="width: 16px; vertical-align:
middle" />
+ <img src="/assets/google.svg" style="width: 16px; vertical-align:
middle" />
Review Comment:
Added alt="GitHub" and alt="Google" to all img elements.
##########
ui/src/views/auth/Login.vue:
##########
@@ -150,9 +150,65 @@
</a-select>
</a-form-item>
</a-tab-pane>
+ <a-tab-pane key="oauth" :disabled="!socialLogin">
+ <template #tab>
+ <span>
+ <img src="/assets/github.svg" style="width: 16px; vertical-align:
middle" />
+ <img src="/assets/google.svg" style="width: 16px; vertical-align:
middle" />
+ External
+ </span>
+ </template>
+ <a-form-item name="oauthDomain">
+ <a-input
+ size="large"
+ type="text"
+ :placeholder="$t('label.domain')"
+ v-model:value="form.oauthDomain"
+ @pressEnter="handleOauthDomainSubmit"
+ @blur="handleOauthDomainSubmit"
+ >
+ <template #prefix>
+ <project-outlined />
+ </template>
+ </a-input>
+ </a-form-item>
+ <div class="center" v-if="oauthGithubProvider || oauthGoogleProvider">
+ <div class="social-auth" v-if="oauthGithubProvider">
+ <a-button
+ @click="handleGithubProviderAndDomain"
+ tag="a"
+ color="primary"
+ :href="getGitHubUrl(from)"
+ class="auth-btn github-auth"
+ style="height: 38px; width: 185px; padding: 0; margin-bottom:
5px;" >
+ <img src="/assets/github.svg" style="width: 32px; padding: 5px"
/>
Review Comment:
Fixed.
##########
ui/src/views/auth/Login.vue:
##########
@@ -150,9 +150,65 @@
</a-select>
</a-form-item>
</a-tab-pane>
+ <a-tab-pane key="oauth" :disabled="!socialLogin">
+ <template #tab>
+ <span>
+ <img src="/assets/github.svg" style="width: 16px; vertical-align:
middle" />
+ <img src="/assets/google.svg" style="width: 16px; vertical-align:
middle" />
+ External
+ </span>
+ </template>
+ <a-form-item name="oauthDomain">
+ <a-input
+ size="large"
+ type="text"
+ :placeholder="$t('label.domain')"
+ v-model:value="form.oauthDomain"
+ @pressEnter="handleOauthDomainSubmit"
+ @blur="handleOauthDomainSubmit"
+ >
+ <template #prefix>
+ <project-outlined />
+ </template>
+ </a-input>
+ </a-form-item>
+ <div class="center" v-if="oauthGithubProvider || oauthGoogleProvider">
+ <div class="social-auth" v-if="oauthGithubProvider">
+ <a-button
+ @click="handleGithubProviderAndDomain"
+ tag="a"
+ color="primary"
+ :href="getGitHubUrl(from)"
+ class="auth-btn github-auth"
+ style="height: 38px; width: 185px; padding: 0; margin-bottom:
5px;" >
+ <img src="/assets/github.svg" style="width: 32px; padding: 5px"
/>
+ <a-typography-text>Sign in with Github</a-typography-text>
+ </a-button>
+ </div>
+ <div class="social-auth" v-if="oauthGoogleProvider">
+ <a-button
+ @click="handleGoogleProviderAndDomain"
+ tag="a"
+ color="primary"
+ :href="getGoogleUrl(from)"
+ class="auth-btn google-auth"
+ style="height: 38px; width: 185px; padding: 0" >
+ <img src="/assets/google.svg" style="width: 32px; padding: 5px"
/>
Review Comment:
Fixed.
##########
ui/src/views/auth/Login.vue:
##########
@@ -339,6 +357,59 @@ export default {
}
})
},
+ fetchOauthProviders (domain) {
+ const params = {}
+ if (domain) {
+ params.domain = domain
+ }
+ if (domain) {
Review Comment:
Consolidated into a single block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
