Damans227 commented on code in PR #12386:
URL: https://github.com/apache/cloudstack/pull/12386#discussion_r2913189950
##########
api/src/main/java/com/cloud/kubernetes/cluster/KubernetesCluster.java:
##########
@@ -98,7 +98,7 @@ enum State {
s_fsm.addTransition(State.Running, Event.ScaleDownRequested,
State.Scaling);
s_fsm.addTransition(State.Stopped, Event.ScaleUpRequested,
State.ScalingStoppedCluster);
s_fsm.addTransition(State.Scaling, Event.OperationSucceeded,
State.Running);
- s_fsm.addTransition(State.Scaling, Event.OperationFailed,
State.Alert);
+ s_fsm.addTransition(State.Scaling, Event.OperationFailed,
State.Running);
Review Comment:
Yea, so basically, on failure, [cleanupNewlyCreatedVms(originalVmIds) (line
524-525)](https://github.com/apache/cloudstack/pull/12386/changes#diff-cfc468cae9bd66b6bfff37def80b0a7e54d96be4d4078f29dc4cbbe4cfe3cef7R525)
destroys only the VMs created during the failed scale-up, so the node count
reverts to the original. That's why transitioning to Runing makes sense here..
and the cluster is still usable at its previous size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
